Merged
Conversation
Spotbugs correctly reported a race condition where the check for insertion of a value might report the value is missing then another thread inserted the value before the current thread performed the `put`. Simpler to `put` the value every time the method is called and then check for the rare case when the value that was put is smaller than the value that was there perviously. Repository size cache is used as a hint. Errors in the size cache may lead to suboptimal choices temporarily, but they should not lead to incorrect behavior.
Add spotbugs exclusions reported as part of the increased checks.
MarkEWaite
added
the
chore
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase spotbugs checks
Increases spotbugs checks by reducing the threshold to "Low". Also resolves a few spotbugs warnings by code corrections.
Inspired by a NonNull annotation in #1468 that should have reported a spotbugs warning and did not.
Checklist
Types of changes